There really are not 9999 feeds. There should be no valid links to this, but the problem is if someone accidentally has display errors on, a hacker can use this very simple "test" to see path information.

Yes, there could be a @ placed somewhere, but this is really a case of checking the input. If there is no feed found, shouldn't it handle it gracefully? I personally think that it should. But, that is JMO.

@guardian, sorry i dont want to do confuse you, first i have to check what the word befuddled means:-)

a & b comes together in my opinion, and the 9999 was just to reproduce and to see what happens if a not existing or not more existing feed was called, because the User has deleted it. And thats the point independent if the feed is not or not more existing there should be no warnings/errors generated in the error logs and not visible in the Browser in my opinion.

Since the feed isn't defined, it has no content type - so it needs to check for a blank content type before loading the class (or stop before that with an error page).
_________________

OK. Here's a solution. In includes/nukeSEO/nukeFEED.php, find:

Code:     $feed = $db->sql_fetchrow($db->sql_query('SELECT * FROM '.$prefix.'_seo_feed WHERE fid = '.$fid));

Insert after:

Code:     if ($feed['content']=='')     { #      header('HTTP/1.0 404 Not Found'); #      header('Status: 404 Not Found');       header('Refresh: 0; url=invalidfeed'.$fid.'.html/', false, 404);       die('Invalid feed');     }

I left the first two headers as comments so you could test all 3 to see which works best for you.

Once I get enough feedback, I'll incorporate into the next release of nukeFEED and SVN for RavenNuke.

i tested it on my side with the following results:

1 header - works and put out 404 in the server logs and stops with Invalid feed in the Browser

2 header - the output is 200 in the server logs and stops with Invalid feed in the Browser - i think not so good

3 header - for me the best solution. put out 404 in the server logs, shows short time the Invalid Feed and redirects to my custom 404 errorpage in the Browser.

i did only a small correction and deleted the / after .html , this was needed to redirect prober to my 404 error page, but this can be happens, because i use the diserrors module for custom error pages...

Brujo

Strange: I also use diserrors on this site, and left the /...

i fixed this with diserror now , so it works with or without the / now..

however, the solution with the errorpage which comes up if a fedd dos not exist solved all the issues. My Logfiles are now clean no more warning & errors and no path information ist shown in the Browser if displays error is on (which i tested only) so i think this will help some Users.

thanks
Brujo